Re: [PATCH] s6-uevent-spawner: Fix possibly delaying uevents

From: Laurent Bercot <ska-skaware_at_skarnet.org>
Date: Sun, 14 Jun 2015 23:18:09 +0200

On 14/06/2015 21:57, Olivier Brunel wrote:
> That is, in your test now you're using x[1] even though it might not
> have been used in the iopause call before, so while I guess this isn't
> random memory, it doesn't really feel right either.

  You're right, of course, that's why the "else" was there in the first
place, and removing it can't be done thoughtlessly.

  I've committed something closer to your patch. It's still simpler
because I eliminated redundant tests.


> and we're gonna block in handle_stdin.

  That was actually another bug... stdin should be non-blocking. >.>
  Fixed.

-- 
  Laurent
Received on Sun Jun 14 2015 - 21:18:09 UTC

This archive was generated by hypermail 2.3.0 : Sun May 09 2021 - 19:38:49 UTC